search

alan-turing-institute / DetectorChecker

Project to develop software to assess developing detector screen damage (Web App based on the original DetectorChecker package)
https://detectorchecker.azurewebsites.net
MIT License
0 stars 1 forks source link

Cannot run user_guide.Rmd #46

Closed OscartGiles closed 5 years ago

OscartGiles commented 5 years ago

When calling

detectorchecker::plot_events_angles(layout_events, row = row_, col = col_, caption = FALSE, incl_event_list = incl_event_list)

on line 311, it fails with error:

Error in disc(R) : radius > 0 is not TRUE

which seems to come from the statspat::rose function.

Seems to run fine when the row and col arguments are removed.

Any ideas @tomaslaz ? In the function .get_clump_event_pp (line 362 in clump.R) there is a comment which says TODO: FIX. Is that related?

tomaslaz commented 5 years ago

This required debugging. I suspect that this error occurs only for special cases (regarding the distribution of defects in the selected panel). Could you please try to investigate this?

OscartGiles commented 5 years ago

No problem. I'll look into it.

OscartGiles commented 5 years ago

Fixed.

There was a layout_events <- detectorchecker::find_clumps(layout_perkin) in the code block before. Needed to run layout_events <- detectorchecker::find_clumps(layout_perkin, row = row_, col = col_) before plotting for a single panel.