search

alan-turing-institute / DetectorChecker

Project to develop software to assess developing detector screen damage (Web App based on the original DetectorChecker package)
https://detectorchecker.azurewebsites.net
MIT License
0 stars 1 forks source link

Merge into master #69

Closed OscartGiles closed 5 years ago

OscartGiles commented 5 years ago

I think we are ready to merge into the master and flip the switch to public.

I could do with getting it public asap so that I can test the links to example files etc on the WebApp (which can't link to these while not public).

The code is passing all tests, but I will also check the build on windows before doing a merge.

Once @ejulia17 and @WilfridSKendall are happy I will merge and make public.

WilfridSKendall commented 5 years ago

I'm happy for you to do this given all checks are complete. @ejulia17 and I discussed whether there should be explicit mention in README.md of who produed the code (@ejulia17 for original code, you two for re-working it all.) I would be very much in favour of this and suggested @ejulia17 supply a draft sentence. Over to you, @ejulia17 ! W PS I may not be easily obtainable on Friday: have to go for routine health-check. Happy for button to be pressed if you are all happy.