search

alan-turing-institute / Palaeoanalytics

Repository for the Paleoanalytics project.
https://www.turing.ac.uk/research/research-projects/palaeoanalytics
GNU General Public License v3.0
17 stars 1 forks source link

@JasonGellis the README and the Travis configuration file still have a mix of pip and conda. Everything works, but I think it makes the installation process more fragile. #139

Closed MichaelHoltonPrice closed 2 years ago

MichaelHoltonPrice commented 3 years ago

I noticed the same thing. I am creating a new issue to make sure this is addressed. Both the main and develop branches still mention conda.

@JasonGellis the README and the Travis configuration file still have a mix of pip and conda. Everything works, but I think it makes the installation process more fragile.

Originally posted by @steko in https://github.com/alan-turing-institute/Palaeoanalytics/issues/130#issuecomment-932872664

JasonGellis commented 3 years ago

Hi @MichaelHoltonPrice, I need a bit of clarification on this issue. Is it that everything is in a conda virtual environment that is the problem? In thed evelop branch we have moved everything to a pip install (still in a Conda virtual environment). Onve JOSS approves this in develop it will be merged to main. If the issues is that you're wanting us to move to a Python virtual environment, we can implement this. Please let me know.

MichaelHoltonPrice commented 3 years ago

It is the README that needs fixing, not the commands or code. Unless I am missing something, conda is not used to install open-cv anymore. Here is the way things currently look in the README:

Install OpenCV using conda and the rest of packages using pip.

pip install .

In other words, "conda install -c conda-forge opencv=4.5.3" used to be in the README, but is now removed. Given that, the line that is currently "Install OpenCV using conda and the rest of packages using pip." in the README should now be "Install packages using pip.", or something like that.

I can't speak to the Travis configuration files since I have never used Travis before. Perhaps @steko can check that the necessary changes have been made.

JasonGellis commented 2 years ago

@MichaelHoltonPrice Thank you for clarifying. I'll get right on it (and the remaining isssues).

JasonGellis commented 2 years ago

@MichaelHoltonPrice please see the updated README installation instructions on this branch: joss_paper/139_native_install https://github.com/alan-turing-institute/Palaeoanalytics/tree/joss_paper/139_native_install

Working on the Travis file now. Once this is aproved by JOSS, I will merge into the main branch.

JasonGellis commented 2 years ago

@MichaelHoltonPrice the README and travis files have been updated for native install and merged into main.

MichaelHoltonPrice commented 2 years ago

Looks good. Thank you! I have opened a new issue regarding Windows syntax, though it is a minor thing.