Closed jack89roberts closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@all-contributors please add @jack89roberts for blog
@crangelsmith
I've put up a pull request to add @jack89roberts! :tada:
@all-contributors please add @jack89roberts for idea
@crangelsmith
I've updated the pull request to add @jack89roberts! :tada:
@all-contributors please add @billfinnegan for review
@crangelsmith
I've put up a pull request to add @billfinnegan! :tada:
@crangelsmith @billfinnegan Thanks again for all your comments! I believe I've now implemented them all, but will give it another read-through tomorrow to double-check. This includes adding markers to show the latest actual values from today in the last plot @crangelsmith , which could be updated again on the date it will be published if you like. I've replied to some of the other suggestions separately above.
I'm happy to help with any of the next publishing steps too - we might find it needs a bit more tweaking to fit the "two narratives" idea, for example.
Hi again @crangelsmith @billfinnegan - I've had a final read through and made some last edits. Let me know if you have any comments on the changes, but otherwise I think it's ready 😄
This is fantastic @jack89roberts , i'll try to give it a second read today. Do you think you could join our meeting on Wednesday? We could work together with @samvanstroud in getting it ready for publishing (e.g different colours for the two narratives, and making sure everything looks good in html, etc).
Sure! There is a meeting about the RDS course 13:00-13:30, but I'm available Weds afternoon otherwise.
Thanks all for writing and reviewing this story @jack89roberts @billfinnegan @crangelsmith ! Merging this now.
Summary
Forecasting when the UK will fully vaccinate the adult population with data collected from the API of the government's Covid-19 dashboard, and using fairly simple approaches such as "when will the population be vaccinated if doses continue to be given at the same rate as the last week?"
Fixes #129
List of changes proposed in this PR (pull-request)
stories/covid-vax/covid_vax.ipynb
)environment.yml
conda environment for dependencies (which are minimal, only requests, pandas, numpy, matplotlib and seaborn) - not sure how dependencies are handled for the stories?20210504_data.json
in case the API changes/is unavailable in the future.What should a reviewer concentrate their feedback on?
Acknowledging contributors