Open mhauru opened 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:21Z ----------------------------------------------------------------
Camila: Rerun on latest data (https://bl.iro.bl.uk/concern/datasets/bb0b3ec4-4667-436a-8e6a-d2e8e5383726?locale=en)
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:22Z ----------------------------------------------------------------
Camila: Check how many people have a full first name. If many have it, we could get gender data based on them, and analyse that.
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:23Z ----------------------------------------------------------------
Camila: Check if qualification is always PhD.
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:23Z ----------------------------------------------------------------
Camila/Markus: This plot needs improving. Some points, ideas:
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:24Z ----------------------------------------------------------------
Maybe put in one figure? Maybe rolling average to smooth?
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:25Z ----------------------------------------------------------------
Keep buzzwords in this story, move all network analysis stuff to its own story.
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:26Z ----------------------------------------------------------------
Try turning this into a figure.
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:26Z ----------------------------------------------------------------
Present more nicely, less long list, more plotty
View / edit / reply to this conversation on ReviewNB
mhauru commented on 2022-04-14T10:47:27Z ----------------------------------------------------------------
This plot is hard to interpret.
@mhauru and @crangelsmith met on the 14th of April and decided to turn this notebook into two stories into two parts.
First part:
Second part:
The comments above help guide the curation of the stories. We will open a new PR with the first part story and keep this one open until the second story is ready for review.
Todo list:
Summary
Copy the notebook from https://github.com/mhauru/EThOS-analysis/blob/master/analysis.ipynb, make minimal edits to make it run. This is a starting point of the PhD thesis metadata (EThOS) story.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors