alan-turing-institute / TuringDataStories

TuringDataStories: An open community creating “Data Stories”: A mix of open data, code, narrative 💬, visuals 📊📈 and knowledge 🧠 to help understand the world around us.
Other
40 stars 14 forks source link

[Review] Using wastewater data to monitor SARS-CoV-2 in England #207

Open mhauru opened 1 year ago

mhauru commented 1 year ago

Story Review: Using wastewater data to monitor SARS-CoV-2 in England

Story Name: Using wastewater data to monitor SARS-CoV-2 in England

Submitting Author: @AoifeHughes (Aoife Hughes)

Pull Request: https://github.com/alan-turing-institute/TuringDataStories/pull/206

Reviewers: @radka-j (Radka Jersakova), @callummole (Callum Mole)

Reviewer instructions & questions

Radka & Callum, please carry out your review in this issue by updating the checklist below, and writing new comments in case you have any questions. If you cannot edit the checklist please:

Any questions, concerns or suggestions regarding the review process please let @crangelsmith, @DavidBeavan or @samvanstroud know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review Checklist

Code of conduct

General checks

Reproducibility

Pedagogy

Context

Ethical

AOB

If you have comments pertaining to particular parts of the story, please use the ReviewNB app to submit them.

Feel free to agree between yourselves on how to divide the review work.

mhauru commented 1 year ago

@all-contributors please add @callummole for review

allcontributors[bot] commented 1 year ago

@mhauru

I've put up a pull request to add @callummole! :tada:

mhauru commented 1 year ago

@all-contributors please add @radka-j for review

allcontributors[bot] commented 1 year ago

@mhauru

I've put up a pull request to add @radka-j! :tada:

mhauru commented 1 year ago

@all-contributors please add @AoifeHughes for ideas

allcontributors[bot] commented 1 year ago

@mhauru

I've put up a pull request to add @AoifeHughes! :tada:

mhauru commented 1 year ago

@all-contributors please add @AoifeHughes for content

allcontributors[bot] commented 1 year ago

@mhauru

I've put up a pull request to add @AoifeHughes! :tada:

mhauru commented 1 year ago

@all-contributors please add @AoifeHughes for code

allcontributors[bot] commented 1 year ago

@mhauru

I've put up a pull request to add @AoifeHughes! :tada:

mhauru commented 1 year ago

@all-contributors please add @AoifeHughes for data

allcontributors[bot] commented 1 year ago

@mhauru

I've put up a pull request to add @AoifeHughes! :tada:

callummole commented 1 year ago

Hi. Very happy to review, but a bit unclear on what I should do. It says please carry out your review in this issue by updating the checklist below. Is the intended interpretation to copy the checklist and add the filled checklist as a comment to this issue?

mhauru commented 1 year ago

No, you can tick boxes in that main checklist in the issue body. This way if you've checked some aspect and ticked it, Radka will know she doesn't have to.

crangelsmith commented 1 year ago

No, you can tick boxes in that main checklist in the issue body. This way if you've checked some aspect and ticked it, Radka will know she doesn't have to.

Just to add to this, it makes sense on the reproducibility side that only one reviewer carries out the checks, but I think in the other sections both reviewers must agree that the requirement is fulfilled, given that it can be a bit more subjective.

callummole commented 1 year ago

I've reviewed the notebook and posted a bunch of comments. Well done, @AoifeHughes, it's looking really nice. Most of my comments are about the modelling.

AoifeHughes commented 1 year ago

Thanks for doing so quickly and throughly @callummole, I’ll go through and address soon! 😊

AoifeHughes commented 1 year ago

Going to address things here and will update this list as I push updates, will notify when complete

For @AoifeHughes todo: