alan-turing-institute / autoemulate

emulate simulations easily
MIT License
18 stars 3 forks source link

Resolve red background on notebook outputs in documentation #152

Closed kallewesterling closed 9 months ago

kallewesterling commented 9 months ago

Fixes #151

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 9 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  logging_config.py
Project Total  

This report was generated by python-coverage-comment-action

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc7a180) 91.72% compared to head (30c915a) 91.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ======================================= Coverage 91.72% 91.72% ======================================= Files 36 36 Lines 1691 1692 +1 ======================================= + Hits 1551 1552 +1 Misses 140 140 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mastoffel commented 9 months ago

@kallewesterling could you give a bit of detail here? When do you see a red background on notebook outputs? Is ch = logging.StreamHandler(sys.stdout) the fix?

kallewesterling commented 9 months ago

Yes, sorry! So when the example notebook below (in the image) would render the outputs, they would look like warnings, but a quick googling showed that this solves it. It's a quirk with JupyterBook I think.

image

kallewesterling commented 9 months ago

@mastoffel would you be able to approve this before our demo meeting, you think?

mastoffel commented 9 months ago

@kallewesterling yes of course, sorry! Happy to merge.