alan-turing-institute / autoemulate

emulate simulations easily
MIT License
15 stars 1 forks source link

Add `RBF` and `CNN1d` to `TorchModule` #179

Closed bryanlimy closed 4 months ago

bryanlimy commented 4 months ago

address https://github.com/alan-turing-institute/autoemulate/issues/165 and https://github.com/alan-turing-institute/autoemulate/issues/160

github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate/emulators
  neural_net_torch.py
  autoemulate/emulators/neural_networks
  base.py 32
  cnn1d.py 60-84
  get_module.py 18
  mlp.py
  rbf.py 16, 20, 24, 28, 32, 36, 112-133, 137-168, 192-201, 222-252, 257, 262, 267, 286-303, 306, 311-333, 336
  tests
  test_emulators.py
Project Total  

This report was generated by python-coverage-comment-action

codecov-commenter commented 4 months ago

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (31c040c) 90.26% compared to head (4b1474a) 87.21%. Report is 3 commits behind head on main.

Files Patch % Lines
autoemulate/emulators/neural_networks/rbf.py 32.65% 66 Missing :warning:
autoemulate/emulators/neural_networks/cnn1d.py 76.31% 9 Missing :warning:
autoemulate/emulators/neural_networks/base.py 83.33% 1 Missing :warning:
...utoemulate/emulators/neural_networks/get_module.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ========================================== - Coverage 90.26% 87.21% -3.06% ========================================== Files 42 44 +2 Lines 1849 2041 +192 ========================================== + Hits 1669 1780 +111 - Misses 180 261 +81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryanlimy commented 4 months ago

RBF is added here https://github.com/alan-turing-institute/autoemulate/pull/180, closing this PR for now and will open a new one for multi-dimension input