alan-turing-institute / autoemulate

emulate simulations easily
MIT License
15 stars 1 forks source link

PyTorch model error with bayes search #199

Closed mastoffel closed 3 months ago

mastoffel commented 4 months ago

This currently doesn't work:

em = AutoEmulate()
em.setup(X, y,param_search=True, param_search_type="bayes", model_subset=["NNMlp"])
best = em.compare()

With this error:

Error fitting model NNMlp
Invalid dimension [<class 'torch.optim.adamw.AdamW'>, <class 'torch.optim.sgd.SGD'>]. Read the documentation for supported types

I guess that this line: "optimizer": [torch.optim.AdamW, torch.optim.SGD], isn't compatible with bayes search at the moment.

kallewesterling commented 4 months ago

@mastoffel Is this perhaps something (as a bug) that needs to be prioritised before AI UK? If so, could you estimate size of this issue?

mastoffel commented 4 months ago

@kallewesterling agree. Size small if it is what I think it is :)

bryanlimy commented 3 months ago

resovled in https://github.com/alan-turing-institute/autoemulate/pull/205