Closed mastoffel closed 3 months ago
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
autoemulate
compare.py
229-231
cross_validate.py
57
hyperparam_searching.py
88-89
logging_config.py
29, 57, 64-65
autoemulate/emulators/neural_networks
mlp.py
tests
test_logging_config.py
Project Total
This report was generated by python-coverage-comment-action
@kallewesterling @bryanlimy if you two are busy, no worries, and I would just go ahead and merge this.
Yeah I think it looks pretty good. Just haven't had a chance to test it out myself but I trust that you have done so! Happy for you to merge.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
LGTM!
Should we allow user to set where to log the file? Or at least make a print statement that logs are being stored to
autoemulate.log
.
Now allowing users to provide a path/filename for the log file, thanks @bryanlimy
Improves logging and adds a progress bar to
compare()
.verbose
argument with 0-2 controls logging to aStreamHandler
(what the user sees in the terminal)log_to_file
now logs everything to file (not controlled by verbose, just everything)logger.exception
now logs errors alongside tracebackscompare
now has a progress bar withtqdm
, which works in notebooks and terminalresolves #68 #126 #127