alan-turing-institute / autoemulate

emulate simulations easily
MIT License
15 stars 1 forks source link

Logging #200

Closed mastoffel closed 3 months ago

mastoffel commented 4 months ago

Improves logging and adds a progress bar to compare().

resolves #68 #126 #127

github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  compare.py 229-231
  cross_validate.py 57
  hyperparam_searching.py 88-89
  logging_config.py 29, 57, 64-65
  autoemulate/emulators/neural_networks
  mlp.py
  tests
  test_logging_config.py
Project Total  

This report was generated by python-coverage-comment-action

mastoffel commented 3 months ago

@kallewesterling @bryanlimy if you two are busy, no worries, and I would just go ahead and merge this.

kallewesterling commented 3 months ago

Yeah I think it looks pretty good. Just haven't had a chance to test it out myself but I trust that you have done so! Happy for you to merge.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mastoffel commented 3 months ago

LGTM!

Should we allow user to set where to log the file? Or at least make a print statement that logs are being stored to autoemulate.log.

Now allowing users to provide a path/filename for the log file, thanks @bryanlimy