Triage whether to add tests and refactor

[griff-rees]

This is a meta ticket to cover cases of refactoring that could ease automating of testing. These may not be viable in the time we have, but to at least keep track of these decisions for the near term versus the long term.

• [x] python/resampling/resampling_hads.py
  • [x] check enforce_date_dropping.py
  • [x] refactor python/resampling/check_calendar.py, which looks like a test as mentioned in https://github.com/alan-turing-institute/clim-recal/issues/32 but isn't incorporated in the pytest configuration. It does require mounting an external drive but doesn't import or call any code from python/resampling/resampling_hads.py. Shifting an equivalent of this to the tests/ folder may be helpful
  • [x] Whether to refactor with tests

The following is postponed until at least #152 is merged.

• ~python/debiasing/pre_processing.py~
  • ~Checking the preprocess_data function may require refactoring~
  • ~Whether to refactor with tests~

[griff-rees]

Much of this was addressed in: https://github.com/alan-turing-institute/clim-recal/pull/145/files#diff-8e0c9562d2bd926b97d59c1f957c6828b334ce4b8030359d5ea710f051f20ba0

• [x] python/resampling/resampling_hads.py -> replaced with python/clim_recal/resampling.py
  • [x] check enforce_date_dropping.py -> replaced with python/clim_recal/utils/xarray.py
  • [x] refactor python/resampling/check_calendar.py, which looks like a test as mentioned in https://github.com/alan-turing-institute/clim-recal/issues/32 but isn't incorporated in the pytest configuration. It does require mounting an external drive but doesn't import or call any code from python/resampling/resampling_hads.py. Shifting an equivalent of this to the tests/ folder may be helpful. -> replaced with python/tests/test_resample.py
  • [x] Whether to refactor with tests -> see python/tests

Below was left on because of concerns with the workflow prior to debiasing. Will reopen a separate ticket for this if addressed in future.

• python/debiasing/pre_processing.py
  • Checking the preprocess_data function may require refactoring
  • Whether to refactor with tests

[griff-rees]

Closing as most of this ticket is addressed, and remaining questions regard timing/decisions meriting separate tickets.