search

alan-turing-institute / clim-recal

Open repository of methods for recalibrating & bias correcting UKCP18 climate projections data
https://alan-turing-institute.github.io/clim-recal/
MIT License
10 stars 1 forks source link

Remove `cmethods` `submodule` #164

Open griff-rees opened 1 month ago

griff-rees commented 1 month ago

Following issue #157, remove the python-cmethods git submodule.

andrewphilipsmith commented 1 month ago

@griff-rees Do you have any idea why the CI is giving a YAMLError on a markdown file? https://github.com/alan-turing-institute/clim-recal/actions/runs/10836170386/job/30069398986?pr=164#step:9:77. The markdown renders fine.

btschwertfeger commented 1 month ago

Dear @andrewphilipsmith and @griff-rees,

thanks a lot for reaching out and addressing #157. I'm fine with the references provided

I've found these places where cmethods is mentioned, but some of those still describe the removed submodule. Could you please check that too:

grep -riIl cmethods .
./.github/workflows/ci.yaml
./docs/pipeline_guidance.qmd
./docs/contributing.md
./docs/assets/pipeline.mermaid
./python/conftest.py
./python/clim_recal/config.py
./python/clim_recal/debiasing/three_cities_debiasing_workshop.sh
./python/clim_recal/debiasing/debias_wrapper.py
./python/clim_recal/debiasing/three_cities_debiasing_cropped.sh
./python/clim_recal/debiasing/run_cmethods.py
./python/clim_recal/debiasing/preprocess_data.py
./python/tests/utils.py
./python/tests/test_debiasing.py
./python/README.md # ignore
./python/pyproject.toml
./README.md
./notebooks/Assessing_bc_data/MethodsAssessment_DecWorkshop.Rmd
./notebooks/Assessing_bc_data/Bias correction assessment.html

I understand the pain of removing all those work, but have you considered to extract the "debiasing" part and distribute it separately using GPL?

All the best!