Implementing age aggregation and last year comparison

alan-turing-institute / daedalus

Daedalus is a novel dynamic spatial microsimulation pipeline that allows users to produce (custom) population projections for policy intervention analysis. Currently, it provides simulation utilities for the whole of the United Kingdom at the local authority (LA) level.

https://alan-turing-institute.github.io/daedalus/

MIT License

5 stars 1 forks source link

Implementing age aggregation and last year comparison #20

Closed crangelsmith closed 3 years ago

crangelsmith commented 3 years ago

Fixes #7 and #8

[x] Aggregates on age buckets the detailed age/sex comparison
[x] Implements comparison on the last year
[x] Refactoring of the main comparison function to be usable in all different comparison levels
[x] Document and comment main functions

crangelsmith commented 3 years ago

Hi @kasra-hosseini, i think this PR is done. This ONS-simulation comparisons can be a bit complicated so it would be very helpful to have some independent pairs of eyes reviewing the functions in the file daedalus/VphSpenserPipeline/ValidationEstimates.py to make sure there are no bugs. Do you have some time in the next couple of days for this?

kasra-hosseini commented 3 years ago

Close this PR, continue the development: https://github.com/alan-turing-institute/daedalus/pull/21