alan-turing-institute / data-classification-app

Classification webapp for the Turing Data Safe Haven
MIT License
4 stars 0 forks source link

Tweak "cannot classify" wording for Project Manager #300

Closed tomdoel closed 4 years ago

tomdoel commented 4 years ago

If a Project Manager clicks Classification for a Work Package, they see the message You cannot classify this work package as you have not been assigned to it. Please add yourself to the work package with a relevant role if you need to go through the classification process.

There are a couple of issues with this:

steven-cd commented 4 years ago

Hmm, you're right - I think that message was written more with the assumption it would be Programme Managers who saw it, who could then assign themselves an appropriate role if necessary. Project Managers definitely can't, at least not without losing their Project Manager privileges. I think in practice though, there are probably very few times where it would be appropriate for either of these roles to actually go through the classification process, so maybe it is best to just change the message to say You cannot classify this work package as you do not have the appropriate role., without any further explanation

tomdoel commented 4 years ago

@steven-cd that would be the simplest change - @bw-faststream do you agree?

bw-faststream commented 4 years ago

I agree, this should fix it well enough

tomdoel commented 4 years ago

Fixed in #315