search

alan-turing-institute / data-classification-app

Classification webapp for the Turing Data Safe Haven
MIT License
4 stars 0 forks source link

Personal data link broken #496

Open rosselton opened 2 years ago

rosselton commented 2 years ago

Summary

At the start of the classification process Question 1 asks: 'Will the research generate (including by selecting, or sorting or combining) any personal data' The personal data is a broken link

(http://localhost:8000/projects/1/work_packages/1/classify/11#personal_data)

What needs to be done?

Fix the link or provide the information by a different method on the page. The text may need rewriting.

Which user story does this task relate to?

440

rosselton commented 2 years ago

This is addressed in PR #499 The link is meant to function as a internal relative link, and in a longer page would jump the user down to a lower section of the page without scrolling, but the page content is so short that it seems as if the link goes no-where and is broken. Since user feedback highlights this as confusing behaviour, the relative link has been removed from the source text.

rosselton commented 2 years ago

@ChristinaLast ChristinaLast 2 days ago Why are we removing these local links? Are they broken?

Author @rosselton rosselton 2 days ago The link is meant to function as a internal relative link, and in a longer page would jump the user down to a lower section of the page without scrolling, but the page content is so short that it seems as if the link goes no-where and is broken. Since user feedback highlights this as confusing behaviour, the relative link has been removed from the source text.

Author @rosselton rosselton 2 days ago It confused me as well at first when I first saw it, I though it was a broken link. Maybe there used to be more text on the page and then it got made shorter at some point. It seems redundant now anyway.

Author @rosselton rosselton 2 days ago This changes appear to be causing the test_classify_guidance to fail.