search

alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
62 stars 15 forks source link

Magic number #1513

Closed JimMadge closed 1 year ago

JimMadge commented 1 year ago

There is a magic number in the code here:

https://github.com/alan-turing-institute/data-safe-haven/blob/f0a890632725e2b6883c8997787294b824caa1cb/data_safe_haven/administration/users/active_directory_users.py#L88-L98

It isn't clear what this number represents and there isn't handling for when it is <6.

jemrobinson commented 1 year ago

Happy to make a quick fix for this but do you want it to be before or after #1506 @JimMadge ?

JimMadge commented 1 year ago

After please 😱