Add more informative error messages to context commands

craddm commented 1 month ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

N/A

Adds more informative messages when users try to use context functions without first having created a context file.

Catches that user is not logged in when trying to create or teardown context infrastructure.

WIP: Catch that no context infrastructure is deployed

Closes #1897 Closes #1899

tested locally

JimMadge commented 4 weeks ago

@craddm Is this ready for review?

craddm commented 4 weeks ago

Pretty much - some tests failing as the commands now error when not logged in with Azure CLI. Do we know how to handle that?

JimMadge commented 3 weeks ago

@craddm Shall I pick up this one?

github-actions[bot] commented 3 weeks ago

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/commands
context.py
data_safe_haven/context_infrastructure
infrastructure.py
data_safe_haven/exceptions
__init__.py
data_safe_haven/external/api
azure_api.py					143, 183, 262, 299, 333, 417, 475, 520, 541, 581, 625, 653, 690, 728, 772, 829, 845-849, 925, 953, 1006, 1038
data_safe_haven/external/interface
azure_authenticator.py					67-68
Project Total