search

alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 14 forks source link

⬆️ Bump urllib3 from 2.2.1 to 2.2.2 #1940

Closed dependabot[bot] closed 6 days ago

dependabot[bot] commented 1 week ago

Bumps urllib3 from 2.2.1 to 2.2.2.

Release notes

Sourced from urllib3's releases.

2.2.2

🚀 urllib3 is fundraising for HTTP/2 support

urllib3 is raising ~$40,000 USD to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects please consider contributing financially to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.

Thank you for your support.

Changes

  • Added the Proxy-Authorization header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via Retry.remove_headers_on_redirect.
  • Allowed passing negative integers as amt to read methods of http.client.HTTPResponse as an alternative to None. (#3122)
  • Fixed return types representing copying actions to use typing.Self. (#3363)

Full Changelog: https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2

Changelog

Sourced from urllib3's changelog.

2.2.2 (2024-06-17)

  • Added the Proxy-Authorization header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via Retry.remove_headers_on_redirect.
  • Allowed passing negative integers as amt to read methods of http.client.HTTPResponse as an alternative to None. ([#3122](https://github.com/urllib3/urllib3/issues/3122) <https://github.com/urllib3/urllib3/issues/3122>__)
  • Fixed return types representing copying actions to use typing.Self. ([#3363](https://github.com/urllib3/urllib3/issues/3363) <https://github.com/urllib3/urllib3/issues/3363>__)
Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/alan-turing-institute/data-safe-haven/network/alerts).
github-actions[bot] commented 1 week ago

Coverage report

This PR does not seem to contain any modification to coverable code.

jemrobinson commented 1 week ago

Note that urllib3 is an indirect dependency (i.e. we do not use anything from it directly) and so packaging guidelines say that we shouldn't constrain its version directly.

I don't see a sensible way to incorporate this fix beyond waiting for one of our dependencies to require it.

JimMadge commented 1 week ago

Note that urllib3 is an indirect dependency (i.e. we do not use anything from it directly) and so packaging guidelines say that we shouldn't constrain its version directly.

I think we don't, at least not in the way the docs are talking about. It isn't in our list of dependencies (pyproject.toml), but it is in the full pinned requirements.txt.

I don't see a sensible way to incorporate this fix beyond waiting for one of our dependencies to require it.

If this PR doesn't break anything I think we can merge.

jemrobinson commented 1 week ago

If this PR doesn't break anything I think we can merge.

We can merge it, but since it's only changing the auto-generated requirements.txt files, it will be reverted the next time the update_python_dependencies workflow runs.

JimMadge commented 1 week ago

We can merge it, but since it's only changing the auto-generated requirements.txt files, it will be reverted the next time the update_python_dependencies workflow runs.

Ah, yes. It might not if other packages don't have strict upper bounds, but I suppose that is out of our control.

jemrobinson commented 6 days ago

@JimMadge : I've found that constraints on dependencies can be specified in another file that only applies to packages that were going to be installed anyway. Added to this PR - let me know what you think.