Postgres database component fixes - Githubissues

alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io

BSD 3-Clause "New" or "Revised" License

61 stars 15 forks source link

Postgres database component fixes #2059

Closed JimMadge closed 3 months ago

JimMadge commented 3 months ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

:closed_umbrella: Related issues

Closes #2056

:microscope: Tests

Tested on fresh deployment,

Databases work (can log in etc., can run smoke tests)
Teardown works without error using workaround

github-actions[bot] commented 3 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/infrastructure/components/composite
postgresql_database.py					30, 83-84
Project Total

This report was generated by python-coverage-comment-action

JimMadge commented 3 months ago

Testing now :+1:

JimMadge commented 3 months ago

Databases are working.

Will check teardown now.

JimMadge commented 3 months ago

Same teardown error.