Closed jemrobinson closed 1 month ago
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
data_safe_haven/external/api
azure_sdk.py
credentials.py
Project Total
This report was generated by python-coverage-comment-action
We recently removed the prompt for users to confirm the credentials, was that because it was difficult to keep in restructuring or because we decided it wasn't a good idea?
Was maybe because it was super annoying to have to reconfirm every time? Doing it the first time makes sense
Because it was prompting during non-interactive sessions (i.e. during Pulumi calls) which caused lock-ups. With this PR we can set the skip_confirmation
flag in the Pulumi code which should mean that the prompt (and associated messages) only happen in the interactive part of the code.
:white_check_mark: Checklist
Enable foobar integration
rather than515 foobar
).develop
.:vertical_traffic_light: Depends on
n/a
:arrow_heading_up: Summary
Currently credential confirmation is written to the logs in unnecessary places (e.g. in the Pulumi output) and the user is not given a chance to check that the credentials are correct.
This adds:
:closed_umbrella: Related issues
n/a
:microscope: Tests
Tested on a fresh SRE deployment and on update