alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
57 stars 15 forks source link

Add application icons #2103

Closed jemrobinson closed 1 month ago

jemrobinson commented 1 month ago

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

n/a

:arrow_heading_up: Summary

IMPORTANT: I am confident that merging this will not affect the findings of the ongoing penetration test

:closed_umbrella: Related issues

n/a

:microscope: Tests

Tested on a fresh SRE deployment

Screenshot 2024-08-06 at 21 17 07
github-actions[bot] commented 1 month ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/infrastructure/programs/sre
  gitea_server.py 339, 353
  hedgedoc_server.py 318, 332
  user_services.py 97, 122
  workspaces.py 59-60
Project Total  

This report was generated by python-coverage-comment-action

jemrobinson commented 1 month ago

@JimMadge : These changes feel bigger than the original PR now. Can you start a new PR for them and revert this to 6d0da02?

Edit: I've made a new branch better-ansible-runtime-variables for these changes and reverted this branch.