Update Nexus Allowlist container images

alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io

BSD 3-Clause "New" or "Revised" License

61 stars 15 forks source link

Update Nexus Allowlist container images #2116

Closed JimMadge closed 2 months ago

JimMadge commented 3 months ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

Update Nexus Allowlist to a release which allows installing archived CRAN packages.

:closed_umbrella: Related issues

Related to #2107

:microscope: Tests

github-actions[bot] commented 3 months ago

Coverage report

This PR does not seem to contain any modification to coverable code.

JimMadge commented 3 months ago

LGTM but are we sure we don't want this in the release-v5.0.0 branch?

I'm not very worried about it but it does change (quite significantly) what you can access through the CRAN proxy.

jemrobinson commented 3 months ago

OK, but we need what goes into v5.0.0 to be deployable. Either we need this fix or we need changes to the smoke tests so they actually work. I'm not sure which is better - what do you think?

JimMadge commented 3 months ago

OK, but we need what goes into v5.0.0 to be deployable. Either we need this fix or we need changes to the smoke tests so they actually work. I'm not sure which is better - what do you think?

I think #2114 should fix the smoke tests without changing the access to packages. I think it might just be that v5.0.0 has a known limitation that you can only install the latest version of each allowed CRAN package in T3. (I think that must have been true in v4 too).

jemrobinson commented 3 months ago

Are you able to easily test whether #2114 actually does fix the smoke tests? If not, let me know and I'll try to deploy something.

jemrobinson commented 3 months ago

Sounds like we might want this to go into release 5.0.0. Am I OK to change the target of this PR @JimMadge ?

JimMadge commented 2 months ago

@craddm @jemrobinson are we happy to put this in for the release?