Ansible: create icons directory

[jemrobinson]

:white_check_mark: Checklist

• [x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• [x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• [x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

:vertical_traffic_light: Depends on

n/a

:arrow_heading_up: Summary

IMPORTANT: I am confident that merging this will not affect the findings of the ongoing penetration test

Create missing /usr/local/share/icons directory in Ansible

:closed_umbrella: Related issues

n/a

:microscope: Tests

Tested on running SRE

[github-actions[bot]]

Coverage report

This PR does not seem to contain any modification to coverable code.

[craddm]

Did you check if

    - name: Copy icons
      ansible.builtin.copy:
        src: "usr/local/share/icons/{{ item }}"
        dest: /usr/local/share/icons/
        mode: '0444'
      loop:
        - gitea.png
        - hedgedoc.png

worked?

Either is way fine I think.

If you mean whether that alone worked with no further changes, that was failing on my VM until I manually created /urs/local/share/icons/

[jemrobinson]

This seems to work

If dest is a non-existent path and if either dest ends with “/” or src is a directory, dest is created.

I'll update the YAML and try again.

[jemrobinson]

@JimMadge : I've simplified a few ansible.builtin.copy tasks to copy everything in src to dest. Unless there's any reason not to do this, I think it's cleaner and minimises the possibility of forgetting to copy a file.

[jemrobinson]

@craddm : I think the trailing / is the thing that triggers whether or not the directory is created.