alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
57 stars 15 forks source link

Fix database password escaping #2125

Closed jemrobinson closed 1 month ago

jemrobinson commented 1 month ago

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

n/a

:arrow_heading_up: Summary

Fix incorrect mustache expansion of database password as this might contain HTML entities

:closed_umbrella: Related issues

Closes #2123

:microscope: Tests

n/a

github-actions[bot] commented 1 month ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/infrastructure
  project_manager.py 82, 277
  data_safe_haven/infrastructure/programs/sre
  gitea_server.py 339, 353
  hedgedoc_server.py 318, 332
  user_services.py 97, 122
  workspaces.py 59-60
  data_safe_haven/logging
  logger.py
  plain_file_handler.py
Project Total  

This report was generated by python-coverage-comment-action

JimMadge commented 1 month ago

@jemrobinson has this been tested?

craddm commented 1 month ago

I'm testing it now

JimMadge commented 1 month ago

@craddm Did it work for you?

craddm commented 1 month ago

Confirmed working