alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 15 forks source link

Add --tier option to provide default settings #2143

Closed jemrobinson closed 2 months ago

jemrobinson commented 2 months ago

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

n/a

:arrow_heading_up: Summary

Add --tier option to provide default settings

:closed_umbrella: Related issues

n/a

:microscope: Tests

Tested on new config generation

github-actions[bot] commented 2 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  config.py
  data_safe_haven/config
  sre_config.py 51-53, 55-57, 59-61, 63-65, 67-69
Project Total  

This report was generated by python-coverage-comment-action

jemrobinson commented 2 months ago

@JimMadge : I don't think it's essential and there are a few things needed here anyway (tests, use an enum). Mainly I think we should have something in the docs that explains how to deploy a tier 0/1/2/3/4 environment. Doesn't have to be this, but we should have some documentation instead in that case.