alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
57 stars 15 forks source link

Pin pyproject dependencies #2154

Closed jemrobinson closed 4 weeks ago

jemrobinson commented 1 month ago

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

n/a

:arrow_heading_up: Summary

Justification:

Potential issues:

:closed_umbrella: Related issues

Part of #2084

:microscope: Tests

Tested on a fork of this repository - dependabot is updating pyproject.toml as expected.

github-actions[bot] commented 1 month ago

Coverage report

This PR does not seem to contain any modification to coverable code.

jemrobinson commented 1 month ago

In principle pinning direct dependencies should be OK. If any of the functions from our directly-called libraries change their behaviour because of the specific version of their dependencies then we actually depend on that library too and we should be explicit about that.

I disagree that having minimal dependencies listed in pyproject.toml is helpful. We actually have no idea whether the set of constraints in this file were correct, because we never used them in development - we were always installing from requirements.txt.

jemrobinson commented 1 month ago

@JimMadge : Transitive dependencies now pinned using hatch-pip-compile