JimMadge commented 2 months ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

:vertical_traffic_light: Depends on

2092

2115

:arrow_heading_up: Summary

:closed_umbrella: Related issues

Closes #2096

:microscope: Tests

Tested on a fresh deployment. All Ansible tasks run correctly.

github-actions[bot] commented 2 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/infrastructure/programs
declarative_sre.py
Project Total

This report was generated by python-coverage-comment-action

JimMadge commented 2 months ago

Some issues with workspaces deploying and getting to the desired state service before the ansible vars file blob has been created.

Trying to fix that by adding a depends_on.

JimMadge commented 1 month ago

Still seems to be a delay between the pulumi resource being created and the file being available over NFS. Adding a line to cloud init to wait for the vars file fixed this.

alan-turing-institute / data-safe-haven

Tidy ansible #2192