alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 15 forks source link

Modify workspace VM cloud-init to facilitate disk mounting and LDAP login #2223

Closed craddm closed 1 month ago

craddm commented 1 month ago

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

Mounts the temporary storage included in some Azure VM SKUs to /mnt/resource instead of /mnt, which prevented proper use of/mntfor our additional storage volumes,input,output, andshared`.

Also moves the restart of the nslcd service to after the completion of the initial desired-state configuration run. The desired state setup modifies nslcd.conf to allow use of ldap login, and the service needed to be restarted to account for this change.

:closed_umbrella: Related issues

Closes #2221

:microscope: Tests

Tested with two separate VMs, a Standard_D2s_v3 (which has a temporary disk) and a Standard_D8s_v5 (which does not).

github-actions[bot] commented 1 month ago

Coverage report

This PR does not seem to contain any modification to coverable code.

craddm commented 1 month ago

LGTM just a suggestion about the mount name.

I've not seen ephemeral0 before. Is there documentation for that?

It's referenced here in the cloud-init docs -

https://cloudinit.readthedocs.io/en/latest/reference/examples.html

You can see an example of some customisation here in Microsoft's docs