alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 15 forks source link

Remove desktop files for gitea/hedgedoc #2226

Closed JimMadge closed 1 month ago

JimMadge commented 1 month ago

These are already provided by templates.

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

Removes desktop files for Gitea and Hedgedoc, which are already provided by templates.

These files would break the idempotence of the desired state play.

:closed_umbrella: Related issues

:microscope: Tests

github-actions[bot] commented 1 month ago

Coverage report

This PR does not seem to contain any modification to coverable code.

jemrobinson commented 1 month ago

What about the ingress/egress/shared desktop files? Should they live here?

JimMadge commented 1 month ago

What about the ingress/egress/shared desktop files? Should they live here?

Yes, those ones are just files that get copied, there are no templates.

(We needed templates for the services as their URLs are not known before run time. The files this PR removes wouldn't work as they are missing that field.)