Closed craddm closed 1 month ago
N.B. Should this target 5.0.1-rc1 instead of develop? Sounds like a bugfix we will want in the patch release.
N.B. Should this target 5.0.1-rc1 instead of develop? Sounds like a bugfix we will want in the patch release.
Could do; but depends if we're merging develop into 5.0.1-rc1, as this is up-to-date with develop rather than based on 5.0.1-rc1
@craddm : Sorry, for this to work you should probably grab that single commit and apply it on top of release-v5.0.1rc1
.
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
data_safe_haven/config
context.py
Project Total
This report was generated by python-coverage-comment-action
Could you check for other places where the description is used?
It isn't ideal that it lives in the context but I think we should ensure changing it doesn't produce any destructive operations.
I haven't spotted anywhere else - every other use I've found is just for information (e.g. printing messages to console)
:white_check_mark: Checklist
Enable foobar integration
rather than515 foobar
).develop
.:vertical_traffic_light: Depends on
:arrow_heading_up: Summary
Uses the SHM/context name as part of the name of the Entra application, instead of the description.
This ensures the application will have a consistent name.
:closed_umbrella: Related issues
Closes #2242
:microscope: Tests
Tested locally