alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 15 forks source link

Use SHM name instead of description for Entra app #2243

Closed craddm closed 1 month ago

craddm commented 1 month ago

:white_check_mark: Checklist

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

Uses the SHM/context name as part of the name of the Entra application, instead of the description.

This ensures the application will have a consistent name.

:closed_umbrella: Related issues

Closes #2242

:microscope: Tests

Tested locally

jemrobinson commented 1 month ago

N.B. Should this target 5.0.1-rc1 instead of develop? Sounds like a bugfix we will want in the patch release.

craddm commented 1 month ago

N.B. Should this target 5.0.1-rc1 instead of develop? Sounds like a bugfix we will want in the patch release.

Could do; but depends if we're merging develop into 5.0.1-rc1, as this is up-to-date with develop rather than based on 5.0.1-rc1

jemrobinson commented 1 month ago

@craddm : Sorry, for this to work you should probably grab that single commit and apply it on top of release-v5.0.1rc1.

github-actions[bot] commented 1 month ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/config
  context.py
Project Total  

This report was generated by python-coverage-comment-action

craddm commented 1 month ago

Could you check for other places where the description is used?

It isn't ideal that it lives in the context but I think we should ensure changing it doesn't produce any destructive operations.

I haven't spotted anywhere else - every other use I've found is just for information (e.g. printing messages to console)