alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io
BSD 3-Clause "New" or "Revised" License
61 stars 15 forks source link

Enhance the teardown documentation for clarity #2252

Closed edwardchalstrey1 closed 3 weeks ago

edwardchalstrey1 commented 1 month ago

:white_check_mark: Checklist

:ledger: Where is the problem?

https://data-safe-haven.readthedocs.io/en/develop/management/index.html#removing-a-deployed-data-safe-haven

:memo: Required documentation changes

craddm commented 1 month ago

On this note, maybe we should be preventing the SHM from being torn down if any SREs are still deployed... or at least give a warning

jemrobinson commented 1 month ago

+1 for prevention (with an error message explaining why).

edwardchalstrey1 commented 1 month ago

On this note, maybe we should be preventing the SHM from being torn down if any SREs are still deployed... or at least give a warning

Also, perhaps in both teardown scripts multiple "Are you sure you really want to do this" prompts

JimMadge commented 1 month ago

@craddm Shall I take this one so you can focus on #2146?

craddm commented 1 month ago

Made some edits in #2254

JimMadge commented 1 month ago

Great 🚀.

I think the other thing to do is make some code changes,

We can do that in another PR. I would be happy bumping that to 5.0.2, what do you think?