[WIP] Prevent teardown of SHM if any SREs are deployed within it - Githubissues

alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io

BSD 3-Clause "New" or "Revised" License

61 stars 15 forks source link

[WIP] Prevent teardown of SHM if any SREs are deployed within it #2256

Closed craddm closed 3 weeks ago

craddm commented 3 weeks ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

Checks for deployed SREs within an SHM and prevents dsh shm teardown if any are found.

:closed_umbrella: Related issues

Related to #2252

:microscope: Tests

Tested locally

github-actions[bot] commented 3 weeks ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/infrastructure/programs
imperative_shm.py					175-180
Project Total

This report was generated by python-coverage-comment-action

JimMadge commented 3 weeks ago

Hmm, I think this got closed when the target branch was deleted.

Sorry @craddm 🙇! Are you able to change the target to develop?

craddm commented 3 weeks ago

Won't let me - it's fine, I'll do a new one for develop

JimMadge commented 3 weeks ago

That's a pain, you still have your branch locally though?

craddm commented 3 weeks ago

Yep!

jemrobinson commented 3 weeks ago

The GitHub interface is infuriating sometimes!