Add confirmation checks and check for deployed SREs before teardown operations - Githubissues

alan-turing-institute / data-safe-haven

https://data-safe-haven.readthedocs.io

BSD 3-Clause "New" or "Revised" License

61 stars 15 forks source link

Add confirmation checks and check for deployed SREs before teardown operations #2266

Closed craddm closed 2 weeks ago

craddm commented 2 weeks ago

:white_check_mark: Checklist

[x] You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
[x] You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
[x] Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

:vertical_traffic_light: Depends on

:arrow_heading_up: Summary

Prevents SHM teardown if an SRE linked to the current SHM is deployed, and adds a confirmation step before teardown

Adds a confirmation step before SRE teardown

:closed_umbrella: Related issues

Closes #2252

:microscope: Tests

Tested locally

github-actions[bot] commented 2 weeks ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/commands
shm.py					156-157
sre.py
data_safe_haven/infrastructure/programs
imperative_shm.py
Project Total

This report was generated by python-coverage-comment-action