`dsh config available` is not showing deployed SREs

[cptanalatriste]

:white_check_mark: Checklist

• [x] I have searched open and closed issues for duplicates.
• [x] This is a problem observed when deploying a Data Safe Haven.
• [x] I can reproduce this with the latest version.
• [x] I have read through the documentation.
• [x] This isn't an open-ended question (open a discussion if it is).

:computer: System information

• Operating System: macOS
• Data Safe Haven version: Data Safe Haven 5.0.1

:package: Packages

List of packages

```none Paste list of packages here ```

:no_entry_sign: Describe the problem

The SRE with ID testt2hdl is live and accessible over https://testt2hdl.prod5.turingsafehaven.ac.uk/. However, when listing deployed SREs using dsh config available we see the following:

┏━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ SRE Name   ┃ Deployed ┃
┡━━━━━━━━━━━━╇━━━━━━━━━━┩
│ cgcdemosre │          │
│ edtest2p5  │          │
│ edtestp5   │          │
│ sbox123    │          │
│ testsre    │          │
│ testt2hdl  │          │
└────────────┴──────────┘

Notice no SRE is marked as deployed.

:deciduous_tree: Log messages

Relevant log messages

```none Your log details here ```

:recycle: To reproduce

Just run dsh config available from any account with production access. @dsj976 and @helendduncan were able to reproduce.

[JimMadge]

Quite likely due to underscores in the SRE name being handling inconsistently. Retained in some places, changed to hyphens, stripped completely.

[craddm]

The name of the SRE from the config is passed through a function (json_safe) that strips out anything other than alphanumeric characters. So, on upload, a config where the SRE name is leon_ardo gets saved as a config file called sre-leonardo.yaml; but the SRE name in the config itself stays as leon_ardo, and that name is what is used in other places internally (e.g. in the list of Pulumi projects in Pulumi.yaml).

This is what leads to dsh config available not picking up that SREs are deployed - the left column is derived from the filename, but is checked against a list from Pulumi.yaml, which is derived from the names inside the config files.

Inputs to dsh config show <name> are also sanitised in the same way. So you could write dsh config show le~on_ar#do! and it would still show you the file sre-leonardo.yaml.

Probably best to switch to allowing underscores and hyphens as well as alphanumeric characters, which is what is allowed to be in the name field of the config.