search

alan-turing-institute / distinctipy

A lightweight package for generating visually distinct colours.
https://distinctipy.readthedocs.io/en/latest/
MIT License
237 stars 13 forks source link

Hint for python typing that pastel_factor is a float #30

Closed coderesting closed 1 year ago

coderesting commented 1 year ago

_pastelfactor is currently assumed to be an integer by the type checker. Changing "0" to "0." fixes this.

jack89roberts commented 1 year ago

Thanks @coderesting - I'll plan to merge this later this week.

jack89roberts commented 1 year ago

Actually black doesn't like 0., could you change them to 0.0 (otherwise I can when I get around to this)?

codecov[bot] commented 1 year ago

Codecov Report

Merging #30 (cf0f897) into main (9f9f15e) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head cf0f897 differs from pull request most recent head 00e6161. Consider uploading reports for the commit 00e6161 to get more accurate results

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files           6        6           
  Lines         375      375           
=======================================
  Hits          319      319           
  Misses         56       56
Files Changed Coverage Δ
distinctipy/__init__.py 100.00% <100.00%> (ø)
distinctipy/distinctipy.py 88.60% <100.00%> (ø)