alan-turing-institute / eider

eider: an R package for processing health records declaratively
https://alan-turing-institute.github.io/eider/
Other
2 stars 0 forks source link

Type checking between specification and data #51

Closed helendduncan closed 7 months ago

helendduncan commented 8 months ago

For example with prescribing data - the code for the bnf_section might be "0102", a string. But user may specify in the json that they want to search for 102, an int. Suggestion is to put in warning/error that type from spec doesn't match type in data. Don't try to fix it...

id    paid_date       bnf_section   num_items
------------------------------------------------
19    2017-12-15      "0106"         3
19    2016-08-11      "0103"         5
...
      "subfilter_1": {
        "column": ["bnf_section"],
        "type": ["IN"],
        "value": [102]
...
helendduncan commented 7 months ago

Actually already addressed in issue #31