search

alan-turing-institute / empiarreader

Reader for EMPIAR datasets
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Updating poetry/pyproject dependencies #20

Closed JatGreer closed 1 year ago

JatGreer commented 1 year ago

Addresses issue #16

Allows empiarreader to be installed via poetry according to README.md instructions. During bug-fixing of pyproject.toml and poetry.lock interactions (pytest >6.2.5 required), I reorganised repo structure. Feel free to change it back if preferred!

I add the file tests/test_empiar_cache.py in which I have a couple of functions I used to try out the functionality of empiarreader. In these I also started to look at whether setting intake cache parameters to non-defaults would allow enable persistent caching of downloaded files. Testing this is incomplete.

Whilst doing these tests I noticed that they will fail if I try to access EMPIAR entry 10340 instead of 10943 (used in other tests). Perhaps tests/test_empiar_cache.py would be a good candidate to extend to investigate why empiarreader breaks on entry 10340?

ots22 commented 1 year ago

Thanks @JatGreer

Moving the package to src got me thinking about the project structure/name again. I have some other ideas that I'll put on another PR after we merge this one.

~tests/test_empiar_cache.py - this has some notes/exploration which seems valuable, but don't think it is testing anything (yet, maybe) since we're not doing caching. Okay to repurpose this into a test for the download functionality?~ (Sorry, please ignore - I missed the part of your message noting this was incomplete)

Will merge as is.

ots22 commented 1 year ago

Whilst doing these tests I noticed that they will fail if I try to access EMPIAR entry 10340 instead of 10943 (used in other tests). Perhaps tests/test_empiar_cache.py would be a good candidate to extend to investigate why empiarreader breaks on entry 10340?

Ah interesting, I'll open an issue for investigating this