Closed bnubald closed 8 months ago
Name | Link |
---|---|
Latest commit | bb923c75ffc51f2105e68c66ab2aac0c25b294d3 |
Latest deploy log | https://app.netlify.com/sites/the-environmental-ds-book/deploys/65dcbf3e0e73c20008093756 |
Deploy Preview | https://deploy-preview-225--the-environmental-ds-book.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@bnubald thanks for opening the PR. I think we can close this PR as #226 works without pinning Sphinx's dependencies.
@bnubald thanks for opening the PR. I think we can close this PR as #226 works without pinning Sphinx's dependencies.
Sure!
Had thought there might have been a reason for keeping jupyter-book pinned to the older version, but happier with the updated jupyter-notebook version. 😄
Closing in exchange for #226.
Summary
Fixes #224
Attempting to build the Jupyter book with current requirements file fails. This PR pins the Sphinx's dependencies which have been updated and are not backwards compatible with older versions (<5.0), this is to allow the currently pinned jupyter-book version (0.12.3) to be kept at that version.
List of changes proposed in this PR (pull-request)
environment.yml
andrequirements.txt
files.Any feedback would be appreciated, especially if others are running into the same issue.
What should a reviewer concentrate their feedback on?
Acknowledging contributors