Store graph `NODE_FEATURES` in the graph once for development 🌐 - Githubissues

alan-turing-institute / grace

Graph Representation Analysis for Connected Embeddings

Other

34 stars 1 forks source link

Store graph `NODE_FEATURES` in the graph once for development 🌐 #286

Closed KristinaUlicna closed 1 year ago

KristinaUlicna commented 1 year ago

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

Script to append all .grace folders in the given path with nodes.parquet file which holds the NODE_FEATURES
GraphAttrs.NODE_FEATURES are now in the graph so that the feature extraction doesn't have to be repeated at every run
If you don't want to re-run the feature extraction, supply None (default) to the config.extractor_fn

List of proposed changes / linked issues & discussions

[x] ✅ Resolves #276

What should a reviewer concentrate their feedback on?

🏃 Scripts to run

https://github.com/alan-turing-institute/grace/blob/4feae20cadcdea63b4e819b65de30ded6b7770a2/grace/simulator/README.md?plain=1#L32-L38

📝 Everything looks OK?

What type of PR is this? (check all applicable)

🪄 Feature
️⃣ Documentation / code annotation
🧑‍💻 Code refactor / style

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need some help

PR review summary

Describe what this PR does & how you reviewed the individual items, where needed:

Some helper checks to tick off:

Focus on image annotation
Focus on model training
Could any optimization be applied?
Is there any redundant code?
Are there any spelling errors?

In conclusion, after my review, I'd like to:

🙋 ask some clarifying questions
🙅 suggest some specific changes