Click.option with flexibility to show features in napari annotator 🎨 - Githubissues

alan-turing-institute / grace

Graph Representation Analysis for Connected Embeddings

Other

34 stars 1 forks source link

Click.option with flexibility to show features in napari annotator 🎨 #288

Closed KristinaUlicna closed 1 year ago

KristinaUlicna commented 1 year ago

PR contribution summary

Why is this PR useful / good for? Please describe the problem(s) you're trying to address.

Allows the user to control a flexible show_features parameter to add (optional) node features to the annotator
Fixes a typo -> image_path was typed incorrectly (=str instead of : str)

List of proposed changes / linked issues & discussions

[x] Resolves #289

What should a reviewer concentrate their feedback on?

🏃 Notebooks to run: examples/show_data.py

What type of PR is this? (check all applicable)

🪄 Feature
️⃣ Documentation / code annotation

Added tests?

🙅 no, because they aren't needed

PR review summary

Describe what this PR does & how you reviewed the individual items, where needed:

Some helper checks to tick off:

Focus on image annotation
Focus on model training
Could any optimization be applied?
Is there any redundant code?
Are there any spelling errors?

In conclusion, after my review, I'd like to:

🙋 ask some clarifying questions
🙅 suggest some specific changes