Closed KristinaUlicna closed 10 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Question:
If I already have the graph attributes saved in my graph but I want to update them I should also set: store_graph_attributes_permanently
: True?
In that case some suggestions:
store_graph_attributes_permanently: False
is very well documented/described but when is true we should log it too. After some offline discussions & design re-consideration, this PR lost on value as the issues can be approached differently, without needing to store the NODE_FEATURES
vector in the written-out graph. This gets addressed in #329 . Closing this deprecated PR now.
PR contribution summary
Why is this PR useful / good for? Please describe the problem(s) you're trying to address.
train
,valid
andinfer
datasetsList of proposed changes / linked issues & discussions
What should a reviewer concentrate their feedback on?
run.py
What type of PR is this? (check all applicable)
Added tests?
test_run.py
to failHints for the reviewer:
At review time, please try a bunch of files which do not have the node features & edge properties in them. Set the
store_graph_attributes_permanently
config hyperparameter toFalse
👇which should throw an error & instructions on what to do. Please follow the instructions until you get to the point where you can successfully train your model 😃
PR review summary
Describe what this PR does & how you reviewed the individual items, where needed:
Some helper checks to tick off:
In conclusion, after my review, I'd like to: