nginx-ingress was renamed to ingress-nginx (updated in #311). Config section wasn't updated to match, which meant ingress controller config has been having no effect
ingress-nginx config now has its desired effect, specifically: scoping the ingress controller to its own namespace, and increasing the proxy-body-size (max notebook save size)
What should a reviewer concentrate their feedback on?
[x] ingress-nginx matches name of chart in requirements.yaml
[x] Everything looks ok?
After deploying:
kubectl get configmap -n hub23 hub23-ingress-nginx-controller -o yaml
Summary
nginx-ingress was renamed to ingress-nginx (updated in #311). Config section wasn't updated to match, which meant ingress controller config has been having no effect
What's changed?
ingress-nginxconfig key spelling matches chart dependencyingress-nginxconfig now has its desired effect, specifically: scoping the ingress controller to its own namespace, and increasing the proxy-body-size (max notebook save size)What should a reviewer concentrate their feedback on?
After deploying:
should show a configmap with something like: