Check backend class is functioning as expected

alan-turing-institute / learning-machines-drift

A Python package for monitoring dataset drift in secure environments

4 stars 2 forks source link

Check backend class is functioning as expected #31

Closed sgreenbury closed 1 year ago

sgreenbury commented 1 year ago

[x] Check whether the class Backend(Protocol) is functioning as expected (as an interface)
[x] Consider whether it would be helpful to implement as an abstract base class.

sgreenbury commented 1 year ago

5b58cce90559c8e1b1544310cd95db0f1bca7cbc updates FileBackend to explicitly inherit Backend. It appears previously FileBackend was a virtual base class of Backend (see here, to confirm). The documentation on Protocol implies we're doing static duck-typing.

Next step: check whether explicitly inheriting Backend is also correct.

sgreenbury commented 1 year ago

Closes with #32.