alan-turing-institute / mogp-emulator

Package for fitting Gaussian Process Emulators to multiple output computer simulation results.
MIT License
47 stars 14 forks source link

Tests failing for GPU implementation on v0.6.0 branch #214

Open nbarlowATI opened 2 years ago

nbarlowATI commented 2 years ago

There are currently five tests that fail when running pytest on a GPU-enabled machine. These are all numerical comparison failures and are all (to some extent) understood.

In test_GaussianProcess.py, the tests

In test_fitting.py, the test test_fit_GP_MAP_GPU fails because of a numerical comparison between the fitted theta values and some "expected" ones, which in the CPU equivalent, are just provided by a patched function. For the GPU/C++ implementation there is not an obvious python function to patch in this way.

It is expected that these tests will be updated/fixed in #211.