fastSmoothEMD code review suggestions

[codecov-io]

Codecov Report

Merging #129 into fastSmoothEMD will increase coverage by 14.64%. The diff coverage is 83.72%.

@@                Coverage Diff                 @@
##           fastSmoothEMD     #129       +/-   ##
==================================================
+ Coverage          70.05%   84.70%   +14.64%     
==================================================
  Files                 12       11        -1     
  Lines                835     1007      +172     
==================================================
+ Hits                 585      853      +268     
+ Misses               250      154       -96     

Impacted Files	Coverage Δ
R/net_emd_speed_benchmark.R	0.00% <0.00%> (ø)
R/measures_net_emd.R	73.21% <58.06%> (+0.13%)	:arrow_up:
R/orca_interface.R	81.81% <80.39%> (-1.32%)	:arrow_down:
R/dhist.R	86.11% <83.01%> (-0.18%)	:arrow_down:
R/emd.R	75.72% <89.47%> (+12.91%)	:arrow_up:
R/measures_net_dis.R	91.97% <91.69%> (+23.93%)	:arrow_up:
R/graph_binning.R	100.00% <100.00%> (ø)
R/utility_functions.R	100.00% <100.00%> (ø)
src/fastSmooth.cpp
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a67c2ce...a67c2ce. Read the comment docs.

[codecov-commenter]

Codecov Report

Merging #129 into fastSmoothEMD will increase coverage by 4.49%. The diff coverage is 83.72%.

@@                Coverage Diff                @@
##           fastSmoothEMD     #129      +/-   ##
=================================================
+ Coverage          80.21%   84.70%   +4.49%     
=================================================
  Files                 11       11              
  Lines                748     1007     +259     
=================================================
+ Hits                 600      853     +253     
- Misses               148      154       +6     

Impacted Files	Coverage Δ
R/net_emd_speed_benchmark.R	0.00% <0.00%> (ø)
R/measures_net_emd.R	73.21% <58.06%> (-0.38%)	:arrow_down:
R/orca_interface.R	81.81% <80.39%> (-1.72%)	:arrow_down:
R/dhist.R	86.11% <83.01%> (-0.18%)	:arrow_down:
R/emd.R	75.72% <89.47%> (-0.24%)	:arrow_down:
R/measures_net_dis.R	91.97% <91.69%> (+23.97%)	:arrow_up:
R/graph_binning.R	100.00% <100.00%> (ø)
R/utility_functions.R	100.00% <100.00%> (ø)
src/test_emd_fast_no_smoothing.cpp	96.66% <0.00%> (-0.21%)	:arrow_down:
src/emd_fast_no_smoothing.cpp	100.00% <0.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c25c16...a59cc6f. Read the comment docs.

[codecov-io]

Codecov Report

:exclamation: No coverage uploaded for pull request base (fastSmoothEMD@5c25c16). Click here to learn what that means. The diff coverage is 83.72%.

:exclamation: Current head 14e1c82 differs from pull request most recent head a59cc6f. Consider uploading reports for the commit a59cc6f to get more accurate results

@@               Coverage Diff                @@
##             fastSmoothEMD     #129   +/-   ##
================================================
  Coverage                 ?   84.70%           
================================================
  Files                    ?       11           
  Lines                    ?     1007           
  Branches                 ?        0           
================================================
  Hits                     ?      853           
  Misses                   ?      154           
  Partials                 ?        0           

Impacted Files	Coverage Δ
R/net_emd_speed_benchmark.R	0.00% <0.00%> (ø)
R/measures_net_emd.R	73.21% <58.06%> (ø)
R/orca_interface.R	81.81% <80.39%> (ø)
R/dhist.R	86.11% <83.01%> (ø)
R/emd.R	75.72% <89.47%> (ø)
R/measures_net_dis.R	91.97% <91.69%> (ø)
R/graph_binning.R	100.00% <100.00%> (ø)
R/utility_functions.R	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c25c16...a59cc6f. Read the comment docs.

[codecov-commenter]

Codecov Report

Merging #129 (14e1c82) into fastSmoothEMD (87d00b7) will increase coverage by 14.64%. The diff coverage is 83.72%.

:exclamation: Current head 14e1c82 differs from pull request most recent head a543607. Consider uploading reports for the commit a543607 to get more accurate results

@@                Coverage Diff                 @@
##           fastSmoothEMD     #129       +/-   ##
==================================================
+ Coverage          70.05%   84.70%   +14.64%     
==================================================
  Files                 12       11        -1     
  Lines                835     1007      +172     
==================================================
+ Hits                 585      853      +268     
+ Misses               250      154       -96     

Impacted Files	Coverage Δ
R/net_emd_speed_benchmark.R	0.00% <0.00%> (ø)
R/measures_net_emd.R	73.21% <58.06%> (+0.13%)	:arrow_up:
R/orca_interface.R	81.81% <80.39%> (-1.32%)	:arrow_down:
R/dhist.R	86.11% <83.01%> (-0.18%)	:arrow_down:
R/emd.R	75.72% <89.47%> (+12.91%)	:arrow_up:
R/measures_net_dis.R	91.97% <91.69%> (+23.93%)	:arrow_up:
R/graph_binning.R	100.00% <100.00%> (ø)
R/utility_functions.R	100.00% <100.00%> (ø)
src/fastSmooth.cpp
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8000fa1...a543607. Read the comment docs.

[ots22]

superceded by #149