andeElliott commented 7 years ago

Changed name of method to highlight the fact it can be used with graph features, and added to code to check the case where the feature scores are no longer integer (also checked negative and irrational)

codecov-io commented 7 years ago

Codecov Report

Merging #72 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage    84.2%   84.22%   +0.02%     
==========================================
  Files           7        7              
  Lines         652      653       +1     
==========================================
+ Hits          549      550       +1     
  Misses        103      103

Impacted Files	Coverage Δ
R/orca_interface.R	`85.49% <100%> (+0.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64d9cee...fb6fafb. Read the comment docs.

martintoreilly commented 7 years ago

I'm wondering if the change in name from graphlet degree distribution to histogram is ideal. I'd like the name to make it as clear as possible that no binning is going on. However, we can pick this up as part of the renaming of dhist to emf (empirical mass function) in issue #79.

martintoreilly commented 7 years ago

@andeElliott I made some minor edits to the method documentation to make it clear that we are talking about discrete histograms and pluralised histogram in the new name. Otherwise, this looks great to me and I'll merge once the CI tests complete.

martintoreilly commented 7 years ago

One more PR this month and you'll qualify for a Hacktoberfest t-shirt 😄

alan-turing-institute / network-comparison

Custom weights #72

Codecov Report