fixed fitnesses being invalid for mutate with fitness

alan-turing-institute / p2lab-pokemon

A Python library for running genetic algorithms to optimize Pokemon teams!

BSD 3-Clause "New" or "Revised" License

8 stars 1 forks source link

fixed fitnesses being invalid for mutate with fitness #30

Closed philswatton closed 1 year ago

philswatton commented 1 year ago

This PR:

Fixes a problem wherein if we mutate with probability inverse to fitness, the fitnesses no longer correspond to the new teams after the selection step
Separates out the selection step from the crossover step
Adds match_fn as a parameter to genetic in genetic.py, meaning different match generation functions in matches.py can be passed

I haven't bug tested this at the time of writing so watch out for any mistakes!

phinate commented 1 year ago

On first glance, this seems to be right -- I'll recruit you at some point to write a couple tests in the future though once we sharpen the codebase :D Happy to merge (and will do so)