search

alan-turing-institute / prompto

An open source library for asynchronous querying of LLM endpoints
https://alan-turing-institute.github.io/prompto/
MIT License
18 stars 1 forks source link

Separate ExperimentPipeline and running experiments #59

Closed rchan26 closed 3 months ago

rchan26 commented 3 months ago

Fix #56. Move the code for running experiments into the Experiment class. Experiments can now be run with Experiment.process() and the pipeline ExperimentPipeline still has the Experiment.run() class which uses this new method.

I've moved ExperimentPipeline to it's own file/module now too.

Results in changes in other areas like notebooks and the scripts to run experiments/the pipeline.

Everything seems to work as usual. Will add tests for all of this next.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rchan26 commented 3 months ago

@fedenanni I'm currently working on tests for running experiments and the pipeline in another branch. I imagine that will be a bit larger potentially so better to make them separate PRs. I think we just merge this in if you're happy

fedenanni commented 3 months ago

Ah yea perfect let's do that!