search

alan-turing-institute / python-project-template

15 stars 3 forks source link

:bug: Install pre-commit in update action #31

Closed jack89roberts closed 6 months ago

jack89roberts commented 6 months ago

Should be a quick fix for the update action, which I noticed had failed. You could consider having pre-commit as one of the Python dependencies included in the template as well/instead of this (don't think it is currently)?

phinate commented 6 months ago

That's not a bad shout. I'm used to having one instance (brew install pre-commit), and running pre-commit install to get the hooks working on the repo. But perhaps it's not a good assumption that people will prefer this!

I think I'll strongly consider after I write some proper documentation on setting things up. In the meantime, this should work great :)