alan-turing-institute / rds-course

Materials for Turing's Research Data Science course
https://alan-turing-institute.github.io/rds-course/
31 stars 13 forks source link

[WIP] Streamlining #138

Closed AoifeHughes closed 1 year ago

AoifeHughes commented 1 year ago

This is an ambitious, and possibly stupid suggestion. Thus, I'd suggest each changed file be thoroughly reviewed.

(Which I will do! Would be rude to ask anyone else to check I haven't broken everything.)

m1

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

AoifeHughes commented 1 year ago

Still think 1.1 has too much, but not sure! Need to think about how this is taught and how much material is needed.

AoifeHughes commented 1 year ago

@callummole I just realised I've been merging back-to-back markdown cells - I'm guessing this will make it super annoying with respect to https://github.com/alan-turing-institute/rds-course/pull/126 for making slides?

I'll stop now, but if we do come up with suggestions or guidelines for teaching / prepping slides do let me know, and I'll adjust accordingly (only did this to 1.1. so far, and a few times in other places)

AoifeHughes commented 1 year ago

As per meeting this morning with @callummole - he suggested we use a glossary to store a lot of the removed information caused by streamlinning the notebooks!

AoifeHughes commented 1 year ago

quick thought c503cfacd967d0a941bb398fa972d2b1e3a8da08 and some others have changed names. Can we make a note here to double-check there's no hard references in the book which reference to no dead files?

AoifeHughes commented 1 year ago

I noticed that some grammar things I'd previous fixed had become undone - partly fixed by 044550f

AoifeHughes commented 1 year ago

Latest commit: https://github.com/alan-turing-institute/rds-course/pull/138/commits/7c37bc3c289664e0201658db594e0ee9661f0ea5 still has myst issues, which are linked to exporting / creating slides. Thus, don't impact the course itself or the build. Still, warnings == errors, so this will need fixed soonish.

Will merge this branch once all files are reviewed and verified